Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cubesql): SQL push down support for window functions #7403

Merged
merged 1 commit into from
Nov 11, 2023
Merged

feat(cubesql): SQL push down support for window functions #7403

merged 1 commit into from
Nov 11, 2023

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Nov 11, 2023 •
edited
Loading

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested review from a team as code owners November 11, 2023 04:41
@vercel Vercel
Copy link

vercel bot commented Nov 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-react-d3 ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-react-dashboard ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-react-data-table ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-react-highcharts ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-react-material-ui ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-react-pivot-table ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am
examples-vue-query-builder ⬜️ Ignored (Inspect) Nov 11, 2023 4:41am

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (910a49d) 47.04% compared to head (bba356e) 71.20%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7403       +/-   ##
===========================================
+ Coverage   47.04%   71.20%   +24.16%     
===========================================
  Files         155      326      +171     
  Lines       20829    54258    +33429     
  Branches     5359     5359               
===========================================
+ Hits         9799    38637    +28838     
- Misses      10182    14773     +4591     
  Partials      848      848
Flag Coverage Δ
cube-backend 47.12% <ø> (+0.07%) ⬆️
cubesql 86.21% <81.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 70.08% <ø> (ø)
rust/cubesql/cubesql/src/compile/rewrite/cost.rs 95.45% <100.00%> (ø)
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 92.83% <100.00%> (ø)
...sql/src/compile/rewrite/rules/wrapper/aggregate.rs 98.79% <100.00%> (ø)
...ompile/rewrite/rules/wrapper/aggregate_function.rs 100.00% <100.00%> (ø)
...cubesql/src/compile/rewrite/rules/wrapper/limit.rs 96.42% <ø> (ø)
...l/cubesql/src/compile/rewrite/rules/wrapper/mod.rs 100.00% <100.00%> (ø)
...cubesql/src/compile/rewrite/rules/wrapper/order.rs 100.00% <100.00%> (ø)
...ql/src/compile/rewrite/rules/wrapper/projection.rs 97.56% <100.00%> (ø)
...ubesql/src/compile/rewrite/rules/wrapper/window.rs 100.00% <100.00%> (ø)
... and 8 more

... and 158 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit b1da6c0 into master Nov 11, 2023
@paveltiunov paveltiunov deleted the window-functions-sql-push-down branch November 11, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paveltiunov